Pull Requestin'

-
This week in my Open Source endeavors, our task was to delve deeper in the open source world and try our hand in contributing more by using pull requests. Our professor had tasked us to add a feature to any of one of our peers' programs. Simple enough, except this would be my first time actually tinkering with someone else's code to add an actual contribution, pretty exciting.

So I looked through the list of repos of the class and I decided that I wanted to step out of my comfort zone and try out a program in a language different than mine. Currently, I'm taking a web development class using ASP.NET and wanted to polish my skills in C#, so I found a perfect repo for that from a coursemate, Zayed.


I thought "wow that sounds pretty similar to my program..." so it must have been the perfect fit right? Regardless, I was already quite interested in trying out C# programming and so I read and I learned. My previous knowledge of C++ from previous semesters definitely gave me a huge advantage in reading through the code. Zayed's code is quite good, it seemed like a lot to write from the start and I commend him for that. Even though it is quite messy and he admitted it as well from my conversation with him about it. (I never said it! He did) My task however was quite simpler than writing the whole program, add an additional feature, and there were quite a few easy ones that were listed in the criteria for the lab.

At first I couldn't find any logic for implementing the -v version argument in the code so I added that as a task, but I thought that'd be too simple so I tasked myself with adding other features as well. I opted for optimising the network code to send a head request and adding a time out feature. So into the microsoft docs I went and lots of tabs were opened. But in the end I ultimately figured out how to change the http method sent and how to add a timeout for the request which was fairly simple. Then I wrote the logic down to identify those timeout and tested the code a good amount of times and was satisfied with the results. So I created a pull request.


Later, Zayed replied and informed me that he had already written a v argument to my surprise. What? How? I didn't see it, how could I have missed it? So I went back and reread the code again thoroughly and I'm embarassed to admit that the code block he had written for the v argument was minimised on my visual studios. Yeah.... Not my proudest moment. However, Zayed did say he was enthusiastic about the other 2 ideas I had. So I fixed the code, made a few changes, finalised the branch and re requested another pull request. I tried my best to make as minimal changes as possible so as to not change Zayed's code too much and break or ruin it. I edited the gitignore file to omit some unecessary visual studio setting files that were in the repo and edited the readme a little bit as well.



I had Zayed review the code, he was satisfied and happy with the changes and additions and he merged my pull request. If anyone's interested, Zayed's repository is linked below

CheckLink [https://github.com/abuZayed15/check-link]

Thanks for reading :)

Comments

Post a Comment

Popular posts from this blog

HacktoberFest Entry No.2

-
Image
So around last week I found a great github repo of a chrome extension that previews contents of a webpage when you hover over a link. I stumbled upon it after a suggestion from my professor about taking a look at chrome extensions for a possible repo to contribute to. I'm glad I did because this was a chrome extension that was interesting, seemed practical and had a maintainer who was keen on receiving contributions to better his program. The extension is called Survol First I had to install it and test it out first, can't just contribute to a repo meaninglessly just to force a pr. I tested the extension and liked the functionality, it was useful and is well designed. Makes it all the more exciting for me to try and contribute to it. So I read the docs and learned how the extension worked. It uses a javascript file to inject html elements through the dom and uses mousemove event to detect anchor links to request information of a page, and positions and fills the div with conten...
Read more

Lab 1 : Our First Open Source Contributions

-
So for Lab 1 our tasks were fairly simple. Find a partner to review a repo on and make contributions, no matter the scale, to their code. Be it a suggestion for their code, reporting an issue, or even fixing up small details in their readme. So through slack I partnered up with one of my coursemates  Niaz Much like me, he wrote his code in nodejs, so it was perfect since I can go through his code easier through my understanding of node. His code, though written in the same language, differed from mine a lot. For one, he didn't use yargs so he had to process the arguments manually, and secondly he didn't use fetch and opted for a module called linkinator. No problem, in fact it's an opportunity for me to understand the logic and components that he used. I forked a copy of the repo, cloned it and tested it out for myself. The code worked perfectly as intended and processed urls well. Functionally, I couldn't find find anything in the code I could identify as a flaw or imp...
Read more

Hack.... vemberfest.. PR No. 3

-
Image
OK so this is pretty long overdue (sorry Prof!) And I still have one more pull request to go and that's on me yes. BUT, this week I spent working (or should I say learning) on our course's aggregated blog website which coincidentally, our prof is making us work on this week for the lab, so I guess I got a good head start going on.  So I took on an issue that seemed pretty straight forward in the repo. It was to change the functionality of the search bar when filtered by author. Seemed pretty straightforward enough, so I went ahead, forked the repo and cloned it on my computer. Now the reading begins, the lengthy process of coding. And the fact that this was a whole website coupled with different technologies that I'm not familiar with only made it waaayyy longer, which maybe is a sign that I should have started working on this much much earlier. But that's what happens when your time management skills is hot garbage. Anyways, I spent the next few days learning about eac...
Read more